Page 1 of 1

Display uncommited changes

PostPosted: Thu Feb 13, 2014 4:45 pm
by andreldm
Hello Serge,
First of all I'd like to thank you for this incredible piece of software, it makes my days at work more easier :D
Last week I was very busy and while using DBeaver, I forgot that it was in manual commit mode for one specific connection, so you can imagine that I spent lots of time and energy just to figure out that result of a query with uncommitted changes would never be available to the application.

I think that a message like "# uncommitted changes" in red, maybe on status bar would be useful to avoid such kind of situation. Or at least as visible.
In WinSQL there's a Green Circle in status bar when auto commit is on or a Red when auto commit if off.

Re: Display uncommited changes

PostPosted: Sun Feb 16, 2014 10:41 am
by Serge
Hello,

You may see autocommit toggle in the main toolbar. When you are in transactional mode then Commot/Rollback actions are enabled. Also DBeaver asks you when you disconnect from database and you did any uncommited changes (see screenshot).
But maybe having some additional information about transaction state would be a good feature.
I'll think about it.

Thanks

Re: Display uncommited changes

PostPosted: Thu Apr 03, 2014 12:22 am
by andreldm
Indeed the autocommit toggle in the main toolbar is useful, but not really noticeable nor its icon is intuitive for an unaware user(like me).
Anyway, it should be suffice for now, but more visibility for uncommited changes would be nice too.

Cheers!

Re: Display uncommited changes

PostPosted: Sun Apr 06, 2014 9:12 pm
by Serge
Hello,

I agree. I've tried to change icons for commit/rollback/auto-commit toggle action multiple times. And definitely will do it again :)
But in fact I'm not sure that it is possible to find/create good self-explanatory icons for these actions.
Anyway, I'll try to make it more obvious with text. These actions will have text (Commit/Rollback) right after icons in the main toolbar (I'm going to try it in the next DBeaver version).
And if people won't be terrified by this UI solution - I'll keep it.

Re: Display uncommited changes

PostPosted: Thu May 29, 2014 12:04 pm
by rethus
Can you show, how this Icons looks like (by default), or where I could change to autocommit for a connection.
I can't find the option to change this.

Re: Display uncommited changes

PostPosted: Thu May 29, 2014 1:26 pm
by Serge
You can access them from main toolbar or main menu.
See screenshots (version 2.4.x):

Re: Display uncommited changes

PostPosted: Mon Sep 01, 2014 9:05 am
by rethus

Re: Display uncommited changes

PostPosted: Tue Sep 02, 2014 8:54 am
by Serge

Re: Display uncommited changes

PostPosted: Wed Sep 10, 2014 6:25 pm
by rethus
Seems removing the org.eclipse.e4.workbench\workbench.xmi works.
Locks fine now on dbeaver perspective.