Test Connection doesn't work from Connection Settings page

Note: please leave bug reports and feature requests on

Test Connection doesn't work from Connection Settings page

Postby codebling » Thu Aug 02, 2012 6:54 pm

When creating a new connection, the "Test Connection ..." button becomes enabled as soon as the Server Host is input, but won't work until 'next' or 'back' button is pressed (fails with error "Bad URL: null"). Similarly, if one is on the last page of the new connection wizard and presses back to, for instance, change the password, the change is still not picked up unless the next or back button is pressed.

I haven't been able to compile the source but I wonder if the attached patch might fix the issue.
Attachments
fix_the_dialog_connection_test_issue.zip
untested possible fix
(540 Bytes) Downloaded 886 times
codebling
 
Posts: 79
Joined: Tue May 22, 2012 4:15 pm

Re: Test Connection doesn't work from Connection Settings pa

Postby Serge » Fri Aug 03, 2012 7:46 am

Wow, thanks a lot for this patch!
It fixes the problem and it will be in the next version.

Actually it was first public patch, we have to celebrate ;)
BTW next version will contain build instructions (along with access to version control system).
Serge
 
Posts: 1526
Joined: Sat Feb 26, 2011 8:24 pm
Location: SPb

Re: Test Connection doesn't work from Connection Settings pa

Postby codebling » Fri Aug 03, 2012 5:50 pm

Yay! <dancing>

That's Great! I have been looking at the source for a while, but for the UI stuff it is pretty difficult since I have never used SWT.

As for building, if you're interested I can try to set up maven/ant/ivy as a build system to facilitate compiling (once I see how everything is actually compiled!). Would make it easier for setting up a continuous integration system and for testing, if you start to get more contributors!

PS the forum bans the extension .patch from being attached.
codebling
 
Posts: 79
Joined: Tue May 22, 2012 4:15 pm

Re: Test Connection doesn't work from Connection Settings pa

Postby codebling » Fri Aug 03, 2012 5:56 pm

By the way, when you start getting patches from the public, it's because you have a really great product.

And believe me I have tested a lot of database programs! (all of the open source ones listed as well as a bunch of the proprietary ones). This is a great product so keep up the good work :) And make a donate button !!
codebling
 
Posts: 79
Joined: Tue May 22, 2012 4:15 pm


Return to Support



Who is online

Users browsing this forum: Google [Bot] and 22 guests